-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new phase for bug trimming #1308
Create new phase for bug trimming #1308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the formatted function,
LGTM!
map((response) => { | ||
const issue = this.createIssueModel(response); | ||
this.updateLocalStore(issue); | ||
return issue; | ||
}), | ||
catchError((err) => this.getIssue(issueId)) | ||
); | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no change to this part of the file, a formatting change is not relevant to this PR. Let's remove this change from the PR.
if your ide is automatically formatting this, there should be an option to make it only format parts you modify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Fixes #1306
Changes Made:
phase.model.ts
session.model.ts
permission.service.ts
issue.service.ts
to handle new bug trimming phaseProposed Commit Message:
Additional info
Since we are still enabling students to update during this phase, The following section in
phase-bug-trimming-routing.module.ts
should be updated to the correct IssueComponent.The new public_data setting should be similar to this new configuration