-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issues with lineage graph filtering with client side filtering #125
Conversation
48d6cf1
to
8e440b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caveclient/chunkedgraph.py
Outdated
isinstance(root_id, int) | ||
or isinstance(root_id, np.uint64) | ||
or isinstance(root_id, np.int64) | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
if isinstance(root_id, (int, np.uint64, np.int64))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
timestamp_past=None, | ||
timestamp_future=None, | ||
as_nx_graph=False, | ||
exclude_links_to_future=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these be timestamps or None? then we could use 2 args instead of 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this is slightly different, it depends on whether you want to include links that cross over the boundary or not. For different use cases you might want those or not. For example, when going backward in time, you might want to know the first root_id that comes before the timestamp_past, because that is the root_id that would be current at timestamp_past.
This is necessary on v1 at least where timestamp filtering does not appear to give the result one would want.