Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment props #176

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Add segment props #176

merged 8 commits into from
Apr 8, 2024

Conversation

fcollman
Copy link
Collaborator

@fcollman fcollman commented Apr 5, 2024

Adds posting to new endpoints for segment properties json

@fcollman fcollman force-pushed the add_segment_props branch from 21dda3c to 23169dd Compare April 5, 2024 20:58
@fcollman
Copy link
Collaborator Author

fcollman commented Apr 7, 2024

Discovered some missing features for the new server version constraint system. Fixed.. @bdpedigo take a look.

@fcollman fcollman requested a review from bdpedigo April 7, 2024 21:33
Copy link
Collaborator

@bdpedigo bdpedigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

seems like this should be a minor version change though

@bdpedigo
Copy link
Collaborator

bdpedigo commented Apr 8, 2024

also, wondering if the current release script will effectively bump twice (since that's also part of the build, but it's also in this PR)

@fcollman fcollman merged commit 465d47e into master Apr 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants