Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove factory syntax for subclients #222

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Remove factory syntax for subclients #222

merged 9 commits into from
Oct 14, 2024

Conversation

bdpedigo
Copy link
Collaborator

@bdpedigo bdpedigo commented Sep 10, 2024 •
edited
Loading

Opened

  • Annotation
  • Auth (already done)
  • Chunkedgraph
  • EMannotationSchemas
  • InfoService
  • JsonService
  • L2cache
  • Materialization
  • Skeleton (already done)

Merged

  • Annotation
  • Auth (already done)
  • Chunkedgraph
  • EMannotationSchemas
  • InfoService
  • JsonService
  • L2cache
  • Materialization
  • Skeleton (already done)

@bdpedigo
refactor
a29f100
@bdpedigo
remove pcg chunkedgraph (#224)
39e1281
@bdpedigo
remove factory (#226)
3a180ac
@bdpedigo
remove factory (#225)
5700261
@bdpedigo
Remove JSONService and L2CacheClient factories (#227)
056c8ea 
* remove factory

* remove factory

* remove client mappings

* remove more
@bdpedigo
Merge remote-tracking branch 'origin' into unfactory
e4f4ef5
@bdpedigo
Remove MaterializationClient factory (#229)
522caf3 
* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query
@bdpedigo bdpedigo marked this pull request as ready for review September 17, 2024 22:55
@bdpedigo bdpedigo requested a review from ceesem October 14, 2024 18:46
@bdpedigo bdpedigo merged commit 70ed8d6 into master Oct 14, 2024
16 checks passed
@bdpedigo bdpedigo deleted the unfactory branch October 14, 2024 20:46
ceesem pushed a commit that referenced this pull request Oct 15, 2024
@bdpedigo @ceesem
Remove factory syntax for subclients (#222)
79aedcc 
* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query
fcollman pushed a commit that referenced this pull request Oct 17, 2024
@ceesem @kebwi
@bdpedigo @github-actions
Inequality table integration (#252)
52a8fdf 
* first take before testing

* Added materialization version endpoint check to query entry functions.

* ruff/lint corrections.

* remove unused dicts

* Bump version: 5.30.2 → 5.31.0

* Remove factory syntax for subclients (#222)

* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query

* Redo docs to acomodate factory refactor (#247)

* many doc refactors

* fix formatting

* add node to changelog

* add a date

* minor fixes

* Small doc fixes (#248)

* more small fixes

* formatting

* Bump version: 5.31.0 → 6.0.0

* initial table manager

* tweak bool compares

* validation check on inequalities

* update docs

* add simple properties to class

* fix unintentional file changes with rebase

* fix dangling doc

* do what ruff tells me to do

---------

Co-authored-by: Keith Wiley <keith.wiley@alleninstitute.org>
Co-authored-by: Ben Pedigo <benjamindpedigo@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kebwi pushed a commit that referenced this pull request Oct 23, 2024
@bdpedigo @kebwi
Remove factory syntax for subclients (#222)
c40381b 
* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query
kebwi added a commit that referenced this pull request Oct 23, 2024
@ceesem @kebwi
@bdpedigo @github-actions
Inequality table integration (#252)
f1ae433 
* first take before testing

* Added materialization version endpoint check to query entry functions.

* ruff/lint corrections.

* remove unused dicts

* Bump version: 5.30.2 → 5.31.0

* Remove factory syntax for subclients (#222)

* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query

* Redo docs to acomodate factory refactor (#247)

* many doc refactors

* fix formatting

* add node to changelog

* add a date

* minor fixes

* Small doc fixes (#248)

* more small fixes

* formatting

* Bump version: 5.31.0 → 6.0.0

* initial table manager

* tweak bool compares

* validation check on inequalities

* update docs

* add simple properties to class

* fix unintentional file changes with rebase

* fix dangling doc

* do what ruff tells me to do

---------

Co-authored-by: Keith Wiley <keith.wiley@alleninstitute.org>
Co-authored-by: Ben Pedigo <benjamindpedigo@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kebwi pushed a commit that referenced this pull request Oct 23, 2024
@bdpedigo @kebwi
Remove factory syntax for subclients (#222)
4cbce3b 
* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query
kebwi added a commit that referenced this pull request Oct 23, 2024
@ceesem @kebwi
@bdpedigo @github-actions
Inequality table integration (#252)
c6074a0 
* first take before testing

* Added materialization version endpoint check to query entry functions.

* ruff/lint corrections.

* remove unused dicts

* Bump version: 5.30.2 → 5.31.0

* Remove factory syntax for subclients (#222)

* refactor

* remove pcg chunkedgraph (#224)

* remove factory (#226)

* remove factory (#225)

* Remove JSONService and L2CacheClient factories (#227)

* remove factory

* remove factory

* remove client mappings

* remove more

* Remove MaterializationClient factory (#229)

* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query

* Redo docs to acomodate factory refactor (#247)

* many doc refactors

* fix formatting

* add node to changelog

* add a date

* minor fixes

* Small doc fixes (#248)

* more small fixes

* formatting

* Bump version: 5.31.0 → 6.0.0

* initial table manager

* tweak bool compares

* validation check on inequalities

* update docs

* add simple properties to class

* fix unintentional file changes with rebase

* fix dangling doc

* do what ruff tells me to do

---------

Co-authored-by: Keith Wiley <keith.wiley@alleninstitute.org>
Co-authored-by: Ben Pedigo <benjamindpedigo@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceesem ceesem Awaiting requested review from ceesem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdpedigo