Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use pyproject.toml and new build system #232

Merged
merged 29 commits into from
Nov 22, 2024
Merged

Refactor to use pyproject.toml and new build system #232

merged 29 commits into from
Nov 22, 2024

Conversation

bdpedigo
Copy link
Collaborator

@bdpedigo bdpedigo commented Sep 16, 2024 •
edited
Loading

This PR:

  • removes requirements.txt-like files -> pyproject.toml
  • removes bumpversion -> pyproject.toml (version is specified in one place only, caveclient can read it from there)
  • adds optional dependency path, currently just caveclient[cv] to include a cloudvolume install

TODO:

  • will need to redo github actions, but want to see how people feel about this first

@bdpedigo bdpedigo marked this pull request as ready for review September 19, 2024 16:52
@bdpedigo bdpedigo changed the title Redo build system Refactor to use pyproject.toml and new build system Sep 19, 2024
@ceesem
Copy link
Collaborator

ceesem commented Nov 18, 2024

I'm super in favor of this. What remains to be done to finish this off?

@bdpedigo
Copy link
Collaborator Author

I'm super in favor of this. What remains to be done to finish this off?

Nothing fundamental, just wanted to make sure there's buy in and then would need to redo the github actions a bit

@fcollman
Copy link
Collaborator

i'm bought in

@bdpedigo bdpedigo merged commit 8ecdc1c into master Nov 22, 2024
16 checks passed
@bdpedigo bdpedigo deleted the build-system branch November 22, 2024 20:36
kebwi pushed a commit that referenced this pull request Dec 9, 2024
@bdpedigo @kebwi
Use pyproject.toml and new build system (#232)
5b33f1a 
* draft pyproject.toml

* refactor versioning logic

* try redo dev workflow

* add lockfile

* try sync

* specify test dev

* lock

* remove 3.7

* add ipython

* try no ipython again

* add ipython back in

* add new lock

* test on 3.8 again

* skip locking

* fix venv command

* try uv run

* try oldest supported numpy

* docs

* rename

* fix up actions

* wip actions

* action fixes

* add pyproject.toml to bumpversion

* fix action

* change message name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdpedigo @ceesem @fcollman