This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
submitReport: Capture if the report was originally flagged for review. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmv
force-pushed
the
alexmv/originally-checked
branch
2 times, most recently
from
d14c8ea
to
f981b67
Compare
Because the Journeyman role is randomly chosen for review 15% of the time, and we have no way to log changes to the "pending review" flag, it is not possible to report on if a particular report was _originally_ flagged for review, as that is not predictable from the original `api_log`, nor accurate from the current `report`. Add an immutable-in-the-UI column for if the report was originally chosen for review. We may have better solutions in the future (e.g. using revision objects) but this is a quick and dirty stopgap. A stopgap fix for #274.
alexmv
force-pushed
the
alexmv/originally-checked
branch
from
f981b67
to
1d7a75e
Compare
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 83.58% 83.61% +0.03%
==========================================
Files 140 141 +1
Lines 3679 3686 +7
==========================================
+ Hits 3075 3082 +7
Misses 604 604
Continue to review full report at Codecov.
|
|
I'm going to merge this so we don't lose data that we need for reporting. We can swap to a different solution later, but having the data is necessary to have that backfill. I'm implementing and merging this, rather than switching revisions on for reports (#273), since that's a much larger change in terms of database load, and we've already noticed one place that there were perf implications of revision history (#225). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Journeyman role is randomly chosen for review 15% of the
time, and we have no way to log changes to the "pending review" flag,
it is not possible to report on if a particular report was
originally flagged for review, as that is not predictable from the
original
api_log, nor accurate from the currentreport.Add an immutable-in-the-UI column for if the report was originally
chosen for review. We may have better solutions in the
future (e.g. using revision objects) but this is a quick and dirty
stopgap.
A stopgap fix for #274.