Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor ui issues with Contact DLC ui modifications #1186

Merged
merged 2 commits into from
Jul 27, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 26, 2019

This PR fixes:

  • when Contact DLC is loaded only, when a tab in the ADDON OPTIONS menu is selected, but not focused, the text appears black on black background, when it should remain white. Without Contact DLC, it is supposed to still turn black.

before:
https://i.imgur.com/RmOnPQp.png

after:
https://i.imgur.com/X5jaxix.png

@commy2 commy2 added Bug Fix 1.94 Contact DLC labels Jul 26, 2019
@commy2 commy2 added this to the 3.12.1 milestone Jul 26, 2019
@commy2
Copy link
Contributor Author

commy2 commented Jul 26, 2019

  • When Contact DLC is loaded only, the ADDON OPTIONS button (and all other buttons added to the menu by our framework like ACE Fix Headbug etc.) is centered instead of flush left, because with Contact DLC they changed the behavior of RscButtonMain and also replaced these buttons to inherit from RscButtonMenuLeft (a new class to get the legacy behavior?).

before:
https://i.imgur.com/ELDVxwO.png

after:
https://i.imgur.com/dGEYYsu.png

@commy2 commy2 merged commit b6df6ac into master Jul 27, 2019
@commy2 commy2 deleted the fixOptionsMenuColor branch July 27, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.94 Contact DLC Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant