Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facewear Randomization #1201

Merged
merged 9 commits into from
Sep 7, 2019
Merged

Add Facewear Randomization #1201

merged 9 commits into from
Sep 7, 2019

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Aug 6, 2019

When merged this pull request will:

  • Add working replacement for 'allowedHeadgear' of BIS_fnc_unitHeadgear but on unit level config.
    • Supports BIS_enableRandomization variable and disableRandomization[] mission config.

Integrated from BWMod and modified for better systems support.

Design decisions:

  • Use vanilla allowedFacewear config entry -> automatically works for all mods
  • Overwrite BIS_fnc_unitHeadgear instead -> yes/no? feasible? -> would require mods to make sure init EH calls it (like BIS_fnc_initVehicle), no need with separate function

@jonpas jonpas added the Feature label Aug 6, 2019
@jonpas jonpas added this to the 3.13 milestone Aug 6, 2019
@jonpas jonpas requested a review from commy2 August 6, 2019 15:24
@commy2

This comment has been minimized.

Co-Authored-By: commy2 <commy-2@gmx.de>
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disableRandomization mission config check with a findIf loop

@commy2 commy2 added WIP and removed Needs Testing labels Aug 19, 2019
@jonpas
Copy link
Member Author

jonpas commented Sep 7, 2019

Tested working with the following config:

CBA_facewearList[] = {
    "", 0.5,
    "G_Shades_Black", 0.25,
    "G_Shades_Blue", 0.25,
    "G_Shades_Green", 0.25,
    "G_Shades_Red", 0.25
};

20190907140751_1

disableRandomization[] and BIS_enableRandomization -> false also work correctly: they get "G_Shades_Black" applied and no headgear, which is correct as per their default loadout.

@jonpas jonpas removed the WIP label Sep 7, 2019
@commy2
Copy link
Contributor

commy2 commented Sep 7, 2019

Wikipage for doc?

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2 commy2 merged commit a900057 into master Sep 7, 2019
@commy2 commy2 deleted the facewear-rand branch September 7, 2019 18:49
@commy2 commy2 modified the milestones: 3.13, 3.12.2 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants