Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation - Add French Translations (Ai) #1387

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

Elgin675
Copy link
Contributor

@Elgin675 Elgin675 commented Nov 3, 2020

When merged this pull request will:

  • Add french translations in ai module.

@commy2
Copy link
Contributor

commy2 commented Nov 3, 2020

By using these names, the objects don't appear grouped in the editor I believe.

@Elgin675
Copy link
Contributor Author

Elgin675 commented Nov 4, 2020

@commy2 Indeed.
But I had no choice, to maintain consistency with the third invisible target, whose name I cannot change because it is inherited from vanilla.

If I could, I would have done this :

  • Cible invisible - Soldat
  • Cible invisible - Véhicule
  • Cible invisible - Avion

But CBA_B_InvisibleTarget is inherited from vanilla ("Soldat cible invisible"), so I have no choice.
However, if we could rename CBA_B_InvisibleTarget via stringtable, I would be more than happy to change that.

@commy2
Copy link
Contributor

commy2 commented Nov 5, 2020

Ah, I see. Yeah, that sucks. I would've went with the systematic name anyway, but your call.

Maybe we could just copy paste the token and edit the French entry? Not sure if it's worth that for one language, though maybe there is a point if multiple languages have that oversight.

@Elgin675
Copy link
Contributor Author

Elgin675 commented Nov 5, 2020

Maybe we could just copy paste the token and edit the French entry? Not sure if it's worth that for one language, though maybe there is a point if multiple languages have that oversight.

@commy2 If we could do that, that would be great :) !
I think it could also be useful for some other languages.

@PabstMirror PabstMirror added this to the 3.15.2 milestone Nov 6, 2020
@PabstMirror PabstMirror merged commit 2305b05 into CBATeam:master Nov 17, 2020
@Elgin675 Elgin675 deleted the traductionFR branch November 17, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants