Item Context Menu - Flexible menu width #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
approved these changes
Oct 3, 2022
|
Why multiply the length by 1.1? Doesn't this mean whitespace grows with text length? |
I assume it was for some margin for text inside the control, but dumb one, agree. |
|
Tried to use only width + margins but as we are using listbox with pictures - we need to add margin for picture as well. I searched for it in defines and config, but didn't get any result. From tests it should be something like 0.05, but maybe somebody know exact value or different approach? |
Changes width calculation to use static margins. Fixes width calculation was checking for hidden options
veteran29
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: