Optics - Increase width of hidePeripheralVision
slightly to prevent gaps
#1568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref acemod/ACE3#9141
I can reproduce at those exact resolution and scale/
mine has a gap on the left which is easy to see, but there also is a gap on the right at the edge of the image.
Checking the 3
ctrlPosition
Left:
[-0.918847,-0.563663,0.0890598,2.12733]
Body:
[-0.829787,-1.27305,2.65957,3.5461]
Right:
[1.82979,-0.563663,0.0890598,2.12733]
Add up the widths and you get
2.83769
which is identical to the safezoneWBut I guess it's just a rounding error and the left ends a pixel short of where the body begins?
I think just adding half a pixel should be enough?