Use unique local variable names in CBA_fnc_directCall #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_code
,_return
and_arguments
are common local variable names. This has the problem of these variables potentially overwriting other local variables from the parent scope of whereCBA_fnc_directCall
was executed from.Example:
All other* local variables carry over just fine. By tagging these local variables, we can make this function more flexible without having to pass every local variable as argument.
_x
which is overwritten byconfigClasses
. I could restore_x
too by adding another dummy variable as placeholder, but that requires some additional tricks withparam
(because the game would error if you reference an undefined_x
variable in scheduled env.), so I think it's not worth it.