Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template for a settings file inside a pbo #451

Merged
merged 3 commits into from
Aug 6, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 31, 2016

When merged this pull request will:

  • Adds a template that can be binarized to have a signed settings file inside a PBO
  • Can be used to enforce settings for a whole repository

@PabstMirror Would that work for you?

@commy2 commy2 added the Feature label Jul 31, 2016
@commy2 commy2 added this to the 3.0.1 milestone Jul 31, 2016
@commy2 commy2 changed the title add template for a settings inside a pbo add template for a settings file inside a pbo Jul 31, 2016
@jonpas
Copy link
Member

jonpas commented Jul 31, 2016

That looks handy!

@Killswitch00
Copy link
Contributor

...enforce settings for a whole repository

The term "repository" is confusing. (It is not a term usually associated with playing the game. A user of CBA may wonder "what/where is a/the 'repository'?)

@commy2
Copy link
Contributor Author

commy2 commented Aug 1, 2016

Other suggestion? "modpack" sounds weird.

@Killswitch00
Copy link
Contributor

How about "static settings addon" instead of "repository settings file".

The template shows an example of an addon that can be used to enforce settings for a mod/addon collection or a mission/mission type.

@commy2 commy2 removed the WIP label Aug 6, 2016
@Killswitch00
Copy link
Contributor

Looks good. Needs documentation that users can read (what it is, what it can be used for and so on). This could be in the form of a separate text file in the templates folder or placed in a comment header in the config.cpp

@Killswitch00
Copy link
Contributor

Ok, so no docs then.

@Killswitch00 Killswitch00 merged commit c07e153 into master Aug 6, 2016
@commy2 commy2 deleted the optional-file-for-repository-settings branch August 6, 2016 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants