Expliclty add modifyer settings for Shift/Ctrl/Alt #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref acemod/ACE3#4822
ACE was adding a keybind of
[29, [false, false, false]]
// 29 = CTRL/STRG keyBut CBA keyhandler expects the control param bool to also be true
[29, [false, true, false]]
The same problem also exists in the code that handles rebinding.
It would only add the base key with all modfiers set to false.
That code calls fnc_addKeybind, so we can solve both problems with this fix.