Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expliclty add modifyer settings for Shift/Ctrl/Alt #583

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Conversation

PabstMirror
Copy link
Contributor

Ref acemod/ACE3#4822
ACE was adding a keybind of [29, [false, false, false]] // 29 = CTRL/STRG key
But CBA keyhandler expects the control param bool to also be true [29, [false, true, false]]

The same problem also exists in the code that handles rebinding.
It would only add the base key with all modfiers set to false.

That code calls fnc_addKeybind, so we can solve both problems with this fix.

@PabstMirror PabstMirror added this to the 3.2 milestone Feb 8, 2017
@commy2
Copy link
Contributor

commy2 commented Feb 9, 2017

I know the rest of CBA (or ACE) usually doesn't do it that way, but I think instead of using the magic numbers for the DIK codes, we should use the enums from BI.

#include "\a3\ui_f\hpp\defineDIKCodes.inc" in this components script_component.hpp and then:

DIK_LSHIFT
DIK_RSHIFT
DIK_LCONTROL
DIK_RCONTROL
DIK_LMENU
DIK_RMENU

@commy2 commy2 merged commit 082dd16 into master Feb 10, 2017
@commy2 commy2 deleted the fixModiferKeybinds branch February 10, 2017 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants