Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve settings #606

Merged
merged 3 commits into from
Apr 8, 2017
Merged

improve settings #606

merged 3 commits into from
Apr 8, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 26, 2017 •
edited
Loading

When merged this pull request will:

  • adds optional cba_settings.sqf file for missions and optional userconfig as well as template for a userconfig addon that doesn't require filePatching.
  • reworked ui
  • adds EDITBOX type setting (strings)
  • adds checkbox to overwrite mission by server settings (no longer default), which:
  • fixes Global settings forced on server instead of in mission by default #580
  • bumps required version to 1.68
  • probably fixes a bunch of smaller issues
  • reworked documentation

http://i.imgur.com/EkA4oe2.jpg

notes:

@todo eventually:

  • define in description.ext the location of the cba_settings.sqf in description.ext and if not found default to MISSION_SETTINGS_FILE

@commy2 commy2 added the WIP label Feb 26, 2017
@commy2 commy2 added this to the 3.3 milestone Feb 26, 2017
@commy2 commy2 self-assigned this Feb 26, 2017
@commy2 commy2 changed the title improve settings menu improve settings Mar 1, 2017
@jonpas
Copy link
Member

jonpas commented Mar 6, 2017 •
edited
Loading

Notes from Slack:

magnetar and I were also discussing mission settings, how you can currently only set it in Eden or manually editing .sqm (not even sure if you can do that)
with the same logic as reading userconfig or static settings pbo, it would be possible to have a file eg. cba_settings.sqf in root of mission, that could also be used to set the settings
with higher priority as Eden settings as it can be edited outside of the editor
not sure if it would be best idea to hardcode a file name, but I like that more than telling people how to call specific function (which has all sorts of problems due to stupid init delays people do and whatever)

Would PR it but since @commy2 is restructuring that I won't interfere. 🎃

@nateberkopec
Copy link

cba_settings.sqf

Yes please!

@Dorbedo
Copy link
Contributor

Dorbedo commented Mar 8, 2017

It would be great, if the cba-settings would support the settingtype "STRING" (edit-box).

@commy2 commy2 mentioned this pull request Mar 11, 2017
Closed
@commy2 commy2 force-pushed the settings-improvements branch 2 times, most recently from 0264a1f to a9368d8 Compare March 19, 2017 17:24
@commy2
Copy link
Contributor Author

commy2 commented Mar 19, 2017

@Dorbedo
Is this good enough?
http://i.imgur.com/PzJwlYd.jpg

@commy2
Copy link
Contributor Author

commy2 commented Mar 20, 2017

ref: #580

@commy2 commy2 force-pushed the settings-improvements branch 3 times, most recently from 16340aa to 16af29b Compare March 26, 2017 12:01
@commy2 commy2 added Enhancement and removed WIP labels Mar 26, 2017
Killswitch00
Killswitch00 approved these changes Mar 29, 2017
View reviewed changes
Copy link
Contributor

@Killswitch00 Killswitch00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large changeset, but nothing sticks out as obviously bad. Quite the opposite. 👍

@Neviothr
Copy link
Contributor

Neviothr commented Mar 31, 2017 •
edited
Loading

This is very useful, thank you @commy2.

@commy2
Copy link
Contributor Author

commy2 commented Mar 31, 2017

WIP updated doc
https://gist.github.com/commy2/4db0602cda2f93e2b7ede61c1657b357

@ViperMaul
Copy link
Contributor

ViperMaul commented Mar 31, 2017 •
edited
Loading

Help us test the release candidate:
CBA v3.3.0 RC1

Release Notes:
https://github.com/CBATeam/CBA_A3/milestone/21?closed=1

@commy2 commy2 merged commit 8a87403 into master Apr 8, 2017
@commy2 commy2 deleted the settings-improvements branch April 8, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Killswitch00 Killswitch00 Killswitch00 approved these changes

Assignees

@commy2 commy2

Labels
Enhancement
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Global settings forced on server instead of in mission by default
7 participants
@commy2 @jonpas @nateberkopec @Dorbedo @Neviothr @ViperMaul @Killswitch00