Add sub-categories to settings #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea 👍 Could you add some space above each sub category? This would help to visually separate each sub category. |
|
I like it yeah, would agree that there should be a line's height above the title line 👍 |
commy2
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sorted sub-categories to base categories
ACE has a lot of settings, we don't want to create more base categories than needed.
This will allow better organization while inside of a single category.
(code/ui might be a little rough, mainly just looking for feedback on the idea)
From acemod/ACE3#3563 (comment)
We could even attempt to autogenerate these sub-categories for setting names that follow a standard
GVAR(pattern, but I'm leaning towards leaving it to the mod-makers to fill.