Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates on ESlint issues found on dev branch #25

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Small updates on ESlint issues found on dev branch #25

merged 1 commit into from
Jul 3, 2023

Conversation

jonkiky
Copy link
Collaborator

@jonkiky jonkiky commented Jul 3, 2023 •
edited
Loading

The changes in this PR.

  1. Small updates on ESlint issues found on dev branch
  2. Enlarge the minHeight to avoid the empty space below the footer. Temporary.

@jonkiky jonkiky changed the title Small updates on ESlint issue found on dev branch Small updates on ESlint issues found on dev branch Jul 3, 2023
Alejandro-Vega
Alejandro-Vega approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit e234aca into dev Jul 3, 2023
@jonkiky jonkiky deleted the refine branch July 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

@amattu2 amattu2 Awaiting requested review from amattu2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonkiky @Alejandro-Vega