-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-133 Updating Program/Study #42
Conversation
…ons, and also updated styling to use styled instead. Updated Section B program/studies to retrieve option labels from value and also check equality based on name and abbrev. Fixed TextInput component not clearing the input to empty.
…fixed switchInput toggleContent being conditionally rendered to instead hiding it to keep it in the DOM. Was causing the input properties to be removed from form parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When saving on Section B (without making any changes), I get an error for the dbGaPPHSNumber field. If I interact with the switch before saving, it doesn't occur. Correction...it occurs only when the switch is off.
It doesn't seem to happen on the dev/mvp branch, but if this is unrelated to your changes, we can disregard this issue.
…form to complain input is not focusable when hidden + required
@amattu2 Good catch! It was caused when a hidden input also has a required property, but since the field should be required, then I had to conditionally add that property. I didn't add this field, but was fixing a different problem caused by it which made the unsaved changes dialog come back. I pushed the fixed though, thanks. |
…ation, and an overflow issue
…ouchRequired in the toggleContent. As well as some validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM.
Nice work including new test cases also!
Overview
This PR is to add name and abbreviation to the label for program and study Autocomplete inputs.