CRDCDH-1995 Validation Results Aggregated/Expanded Table Views #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and populating the issueType filter
Pull Request Test Coverage Report for Build 12589515921Details
💛 - Coveralls |
amattu2
requested changes
Jan 2, 2025
| // "All" is the default selection for all filters | ||
| expect(mockMatcher).not.toHaveBeenCalledWith( | ||
| expect.objectContaining({ batchIDs: expect.anything(), nodeTypes: expect.anything() }) | ||
| ); | ||
| expect(mockMatcher).toHaveBeenCalledWith(expect.objectContaining({ severities: "All" })); | ||
| // TODO: FIX TEST | ||
| // expect(mockMatcher).toHaveBeenCalledWith(expect.objectContaining({ severities: "All" })); |
There was a problem hiding this comment.
Is this a TODO for when the API works, or is this broken due to ACT/etc?
Just pointing this out in case it was forgotten. If it is an ACT issue, feel free to leave it commented out. Tracing the root cause for act is a nightmare 😃
| const handleFilterChange = (field: keyof FilterForm) => { | ||
| setTouchedFilters((prev) => ({ ...prev, [field]: true })); | ||
| }; | ||
|
|
||
| const Actions = useMemo<React.ReactNode>( |
There was a problem hiding this comment.
Currently, the export button is only exporting the QC Results. I think the expectation would be that it exports the Aggregated Results when that's selected? I could be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added Aggregated/Expanded view to the table in Validation Results tab in a Data Submission.
Note
The BE currently does not populate issue codes. (They all return as null) which breaks some functionality such as the issue type filter, "Expand" and button. There is also a BE bug when passing -1 for the "first" param of the aggregated submission QC results API.
Change Details (Specifics)
Related Ticket(s)
CRDCDH-2037 (Aggregated View Task)
CRDCDH-1995 (Expanded View Task)
CRDCDH-1889 (US)