-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-2021 Collaborators Dialog Updates #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything generally LGTM. Can't fully test locally since the API isn't updated yet. I commented two super minor things.
BTW, the US was updated with the new dialog content, so we can probably include that in this PR too?
Updated to include new dialog description text in a1d0d61. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Didn't retest changes locally.
Overview
Removed Organization and Access columns from Collaborators dialog table.
Note
The Collaborators dialog needs an updated description. Will update in future PR if still have not received updated text yet.
Note
Haven't tested with BE yet as it is not ready yet, but based my implementation on the existing BE PR.
Change Details (Specifics)
Related Ticket(s)
CRDCDH-2021 (Task)
CRDCDH-1984 (US)