Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spooker call: parse workflow attributes outside groovy function #49

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Oct 16, 2024

Changes

oddly, the old code works in champagne but not in crispin

Issues

NA

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool changed the title fix: parse workflow attributes outside groovy function fix spooker call: parse workflow attributes outside groovy function Oct 16, 2024
@kelly-sovacool kelly-sovacool self-assigned this Oct 16, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review October 16, 2024 18:24
@kelly-sovacool kelly-sovacool merged commit 17fd6a5 into main Oct 16, 2024
3 checks passed
@kelly-sovacool kelly-sovacool deleted the fix-spooker branch October 16, 2024 18:25
@kelly-sovacool kelly-sovacool added this to the 2024-10 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant