Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default tmp dir for biowulf & frce #98

Merged
merged 9 commits into from
Jan 22, 2024
Merged

fix: set default tmp dir for biowulf & frce #98

merged 9 commits into from
Jan 22, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Jan 19, 2024

Changes

Automatically set it to lscratch/$SLURM_JOBID on biowulf or the OUTPUT argument on FRCE.
Still allow users to override the default by setting --tmp-dir on the CLI.

Issues

Testing

  • biowulf
  • frce

without tmp-dir flag on either platform

#!/usr/bin/env bash
RENEE_DIR=/mnt/projects/CCBR-Pipelines/pipelines/RENEE/renee-dev-sovacool
WORKDIR=/scratch/cluster_scratch/$USER/renee_test_v2.5.11
rm -rf $WORKDIR

module load singularity
$RENEE_DIR/bin/renee run \
	--input $RENEE_DIR/.tests/*.R?.fastq.gz \
	--output $WORKDIR \
	--genome hg38_30 \
	--mode slurm \
	--sif-cache /mnt/projects/CCBR-Pipelines/SIFs

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

still allow user override

fixes #79
@kopardev kopardev added the RENEE RepoName label Jan 19, 2024
@slsevilla
Copy link
Contributor

There's a typo in your description changes - can you add the default for force? (right now it says 'out', above)

@kelly-sovacool
Copy link
Member Author

This works for me now on both biowulf and frce, just waiting on @slsevilla's test to complete successfully too.

Copy link
Contributor

@slsevilla slsevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FRCE run no longer has tmp related errors. Merging!

@slsevilla slsevilla merged commit 32d503a into main Jan 22, 2024
1 check passed
@slsevilla slsevilla deleted the iss-79 branch January 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RENEE RepoName
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set default --tmp-dir depending on HPC platform
3 participants