Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lowercase SIFs dir #23

Merged
merged 7 commits into from
Dec 2, 2024
Merged

fix: lowercase SIFs dir #23

merged 7 commits into from
Dec 2, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Dec 2, 2024

Changes

Use SIFs instead of SIFS everywhere.

Also make singularity_sif_dir a dynamic property of the HPC Cluster class to avoid code duplication.

Issues

see CCBR/RENEE#181

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.41%. Comparing base (c338de2) to head (56c2cbd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   31.56%   32.41%   +0.84%     
==========================================
  Files          17       17              
  Lines        1264     1265       +1     
==========================================
+ Hits          399      410      +11     
+ Misses        865      855      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review December 2, 2024 17:13
@kelly-sovacool kelly-sovacool self-assigned this Dec 2, 2024
@kelly-sovacool kelly-sovacool merged commit 3e60ed9 into main Dec 2, 2024
@kelly-sovacool kelly-sovacool deleted the cache branch December 2, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant