feat: sorting glob_files by date #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.4 #83 +/- ##
=======================================
Coverage ? 75.18%
=======================================
Files ? 25
Lines ? 1785
Branches ? 0
=======================================
Hits ? 1342
Misses ? 443
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@kopardev I changed your pull request to merge into main, which is the dev branch. The |
Comment on lines
+124
to
+133
| set of pathlib.Path: A set of `pathlib.Path` objects representing the matched files | ||
| sorted by modification time (newest first) | ||
| """ | ||
| return { | ||
| files = [ | ||
| pathlib.Path(f) | ||
| for pattern in patterns | ||
| for f in glob.glob(f"{pipeline_outdir}/**/{pattern}", recursive=True) | ||
| if pathlib.Path(f).is_file() | ||
| } | ||
| ] | ||
| return sorted(files, key=lambda p: p.stat().st_mtime, reverse=True) |
Member
There was a problem hiding this comment.
this will break existing code that uses glob_files and expects it to be a set
grep -r glob_files src
src/ccbr_tools/spooker.py:from .paths import get_tree, load_tree, get_disk_usage, glob_files
src/ccbr_tools/spooker.py: log_file = glob_files(
src/ccbr_tools/paths.py:def glob_files(
src/ccbr_tools/jobby.py:from .paths import glob_files
src/ccbr_tools/jobby.py: out_files = glob_files(workdir, patterns=[f"*{job_id}*.out", ".command.out"])
src/ccbr_tools/jobby.py: err_files = glob_files(workdir, patterns=[f"*{job_id}*.err", ".command.err"])
kelly-sovacool
requested changes
May 19, 2025
Member
There was a problem hiding this comment.
- Code that uses
glob_files()will likely need to change, e.g.pop()is asetmethod thatlistdoes not have. See comment - Please fill out the PR template, including a brief description of why the change is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
PR Checklist
(
Strikethroughany points that are not applicable.)CHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/