Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade multiqc docker with PYTHONPATH unset #123

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 1, 2024

Changes

upgrade the multiqc docker to use the newer base v7, which has PYTHONPATH unset

Issues

depends on CCBR/Dockers#39

fixes #122

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool
Copy link
Member Author

@samarth8392 the new docker is built, can you test this? you can update the container config in your existing project dir and relaunch the xavier run there.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review November 1, 2024 18:13
@samarth8392
Copy link
Collaborator

XAVIER test run completed successfully. Updated Multiqc docker image worked without error.

@samarth8392 samarth8392 merged commit 885e21a into main Nov 5, 2024
3 checks passed
@samarth8392 samarth8392 deleted the iss-122 branch November 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in MultiQC rule
2 participants