feat: Added velocity hit feature #4878

AlexanderDotH · 2024-12-13T20:25:12Z

Velocity hit feature for KillAura.

The feature

This feature grants an extra hit if the player is lagging while receiving a combo from an opponent.

DataM0del · 2024-12-14T20:43:52Z

get detekted!!!

AlexanderDotH · 2024-12-14T21:32:50Z

Actually no, load the default gomme config and enable this feature. Never got banned, just adjust the extended reach

SuicidalEeper · 2024-12-14T22:03:11Z

Did laugh

AlexanderDotH · 2024-12-14T22:04:47Z

Do what you want I don't care at all

1zun4 · 2024-12-14T22:06:03Z

Actually no, load the default gomme config and enable this feature. Never got banned, just adjust the extended reach

No what he means is the code quality tool "Detekt".

1zun4

Good job. I had a similar idea but didn't get to do it so far, but this looks promising. The code needs clean up though, formatting is quite off and a lot of useless semicolons and empty spaces.

AlexanderDotH · 2024-12-14T22:11:43Z

Thank you it's my first contribution in kotlin

DataM0del

Looks Good To Me ™️, just fix the (unfunny joke start) "detektions" (unfunny joke end)

...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt

DataM0del

These changes should fix the detekt errors:

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/velocity/ModuleVelocity.kt

src/main/kotlin/net/ccbluex/liquidbounce/utils/render/TargetRenderer.kt

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

Co-authored-by: DataModel <183248792+DataM0del@users.noreply.github.com>

1zun4 · 2024-12-16T00:30:05Z

Can you show us a demo of how it works?

...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt

Co-authored-by: DataModel <183248792+DataM0del@users.noreply.github.com>

AlexanderDotH · 2024-12-18T18:45:07Z

Can you show us a demo of how it works?

Yeah add me on discord: alexdoth

1zun4 · 2024-12-19T01:54:49Z

Can you show us a demo of how it works?

Yeah add me on discord: alexdoth

Please send the video clip here, if you have one. Is it for 1.8 or 1.9 combat? Because I have tried it for 1.9 combat and it did not really do what I thought it does.

AlexanderDotH · 2024-12-19T13:30:12Z

It's for 1.8 combat. The feature only extends the reach if the player is lagging or fake lagging. You can also disable this behavior by unchecking the "OnlyWhileLagging" option. In the video, I just set the range extension to 1 and enabled "OnlyWhileLagging". It's more like a legit feature since it only does something in a specific edge case where you are getting combos.

I just added the chat messages in the video to demonstrates at which specific time it worked and not. It will be removed in future PRs.

https://youtu.be/TxYWjrKViO8

LTBlueLatios · 2024-12-27T03:21:11Z

I'd like to point out that this feature is already covered by Backtrack. If you want to nevertheless add this feature because the current Backtrack can't reliably trigger it, then I suggest adding it in Backtrack itself to prevent code pollution.

If anyone is confused, don't be afraid to ask.

AlexanderDotH · 2024-12-27T03:38:42Z

I'm a bit confused, to be honest, because it modifies the behavior of the KillAura, not backtrack. The result would be the same (getting some extra hits on other players), but I think some users will be confused about why the KillAura is hitting further away than set, only to see that backtrack modifies the reach. This feature also works if there is no network "issue".

LTBlueLatios · 2024-12-28T01:06:36Z

I'm a bit confused, to be honest, because it modifies the behavior of the KillAura, not backtrack. The result would be the same (getting some extra hits on other players), but I think some users will be confused about why the KillAura is hitting further away than set, only to see that backtrack modifies the reach. This feature also works if there is no network "issue".

Mb, I assumed most of the context from the description so I didn't look too much into the code.

AlexanderDotH · 2024-12-30T18:07:38Z

@1zun4 will it be merged?

superblaubeere27 · 2024-12-30T22:07:14Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+import net.ccbluex.liquidbounce.utils.client.PacketQueueManager
+import net.minecraft.network.packet.s2c.play.*
+
+object KillAuraVelocityHit : ToggleableConfigurable(ModuleKillAura, "VelocityHit", false) {


Documentation! What does this feature do?

superblaubeere27

Interesting idea.

superblaubeere27 · 2024-12-30T22:08:06Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+        get() = super.running && isPossible
+
+    @Suppress("unused")
+    private val packetHandler = sequenceHandler<PacketEvent>(priority = 1) { event ->


please use one of the priority categories.

superblaubeere27 · 2024-12-30T22:09:11Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+    private var considerVelocityHit = false
+    private var damageReceived = false
+    private var onGroundTicks = 0
+    private var isPossible = false


Documentation!

isPossible is not a very good name

superblaubeere27 · 2024-12-30T22:11:31Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+    private var isPossible = false
+
+    private var timer = Chronometer()
+    private var lastPacketTime = Lists.newLinkedList<Long>()


There are only a handful use cases for linked lists.

The ArrayDeque is the one that you are searching for. It is a ring buffer and has O(1) time complexity when inserting at/removing from the head and tail!

And documentation!

superblaubeere27 · 2024-12-30T22:17:44Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+            packet is EntityDamageS2CPacket && packet.entityId == player.id -> {
+                damageReceived = true
+            }
+            packet is EntityVelocityUpdateS2CPacket && packet.entityId == player.id && damageReceived -> {
+                considerVelocityHit = true
+            }


you have implemented a state machine, but you use two separate flags to keep track of what state the state machine is currently in.

I'd recommend using an enum for the states, for example:

enum PacketListenerState { IDLE, /** * The player received damage, but no velocity packet was received (yet) */ DAMAGE_RECEIVED, /** * A hit with velocity was received. */ VELOCITY_DAMAGE_RECEIVED }

superblaubeere27 · 2024-12-30T22:18:20Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+        var lagging = isLagging() || PacketQueueManager.isLagging
+
+        if (!whenLag) {
+            lagging = true
+        }


Are you sure that this code does what it should?

Suggested change

var lagging = isLagging() || PacketQueueManager.isLagging

if (!whenLag) {

lagging = true

}

var lagging = isLagging() || PacketQueueManager.isLagging || !whenLag

superblaubeere27 · 2024-12-30T22:19:06Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+object KillAuraVelocityHit : ToggleableConfigurable(ModuleKillAura, "VelocityHit", false) {
+
+    val extendRange by float("ExtendRange", 1.0f, 0.1f..2.0f)
+    private val whenLag by boolean("OnlyWhileLagging", false)


superblaubeere27 · 2024-12-30T22:22:27Z

...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt

+        if ((player.isOnGround && isPossible) || (player.fallDistance > 0.3 && isPossible)) {
+            onGroundTicks++
+        }


Suggested change

if ((player.isOnGround && isPossible) || (player.fallDistance > 0.3 && isPossible)) {

onGroundTicks++

}

if (isPossible && (player.isOnGround || player.fallDistance > 0.3)) {

onGroundTicks++

}

feat: Added velocity hit feature

74b8bc3

1zun4 reviewed Dec 14, 2024

View reviewed changes

1zun4 added this to the 0.22.0 milestone Dec 14, 2024

DataM0del suggested changes Dec 14, 2024

View reviewed changes

...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt Outdated Show resolved Hide resolved

DataM0del suggested changes Dec 14, 2024

View reviewed changes

1zun4 and others added 4 commits December 16, 2024 01:13

Apply suggestions from code review

6b2bc8c

Co-authored-by: DataModel <183248792+DataM0del@users.noreply.github.com>

refactor: code clean-up

449033c

refactor: code clean-up

a49cc07

Merge branch 'nextgen' into fork/AlexanderDotH/feature/velocity-hit

321ca9e

1zun4 removed this from the 0.22.0 milestone Dec 16, 2024

github-advanced-security bot found potential problems Dec 16, 2024

View reviewed changes

...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt Fixed Show resolved Hide resolved

Apply suggestions from code review

3faf9f7

Co-authored-by: DataModel <183248792+DataM0del@users.noreply.github.com>

superblaubeere27 reviewed Dec 30, 2024

View reviewed changes

superblaubeere27 requested changes Dec 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added velocity hit feature #4878

feat: Added velocity hit feature #4878

AlexanderDotH commented Dec 13, 2024 •

edited

Loading

DataM0del commented Dec 14, 2024

AlexanderDotH commented Dec 14, 2024

SuicidalEeper commented Dec 14, 2024

AlexanderDotH commented Dec 14, 2024

1zun4 commented Dec 14, 2024

1zun4 left a comment

AlexanderDotH commented Dec 14, 2024

DataM0del left a comment

DataM0del left a comment •

edited

Loading

1zun4 commented Dec 16, 2024

AlexanderDotH commented Dec 18, 2024

1zun4 commented Dec 19, 2024 •

edited

Loading

AlexanderDotH commented Dec 19, 2024 •

edited

Loading

LTBlueLatios commented Dec 27, 2024

AlexanderDotH commented Dec 27, 2024

LTBlueLatios commented Dec 28, 2024

AlexanderDotH commented Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 left a comment

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

superblaubeere27 Dec 30, 2024

feat: Added velocity hit feature #4878

Are you sure you want to change the base?

feat: Added velocity hit feature #4878

Conversation

AlexanderDotH commented Dec 13, 2024 • edited Loading

The feature

DataM0del commented Dec 14, 2024

AlexanderDotH commented Dec 14, 2024

SuicidalEeper commented Dec 14, 2024

AlexanderDotH commented Dec 14, 2024

1zun4 commented Dec 14, 2024

1zun4 left a comment

Choose a reason for hiding this comment

AlexanderDotH commented Dec 14, 2024

DataM0del left a comment

Choose a reason for hiding this comment

DataM0del left a comment • edited Loading

Choose a reason for hiding this comment

1zun4 commented Dec 16, 2024

AlexanderDotH commented Dec 18, 2024

1zun4 commented Dec 19, 2024 • edited Loading

AlexanderDotH commented Dec 19, 2024 • edited Loading

LTBlueLatios commented Dec 27, 2024

AlexanderDotH commented Dec 27, 2024

LTBlueLatios commented Dec 28, 2024

AlexanderDotH commented Dec 30, 2024

Choose a reason for hiding this comment

superblaubeere27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexanderDotH commented Dec 13, 2024 •

edited

Loading

DataM0del left a comment •

edited

Loading

1zun4 commented Dec 19, 2024 •

edited

Loading

AlexanderDotH commented Dec 19, 2024 •

edited

Loading