[Fix][QA] 전역적으로 단순한 QA(0422) 처리 및 디버깅 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysh4296
reviewed
Apr 23, 2023
| // height: 1, | ||
| // }, | ||
| // shadowOpacity: 0.25, | ||
| // shadowRadius: 1.84, |
src/types/Feed/Feedinsights.d.ts
Outdated
| @@ -16,11 +16,11 @@ export interface InsightData { | |||
| writer: InsightWriter; | |||
| } | |||
|
|
|||
| interface Link { | |||
| export interface Link { | |||
There was a problem hiding this comment.
.d.ts 파일에서는 export를 사용하지 않습니다.
타입선언 전용 파일인데 컴파일러가 이를 인식하여 전역적으로 사용할 수 있도록 바꾸어주기 때문입니다.
export로 변경하며 다른 변경사항들이 있었을꺼같은데 롤백해주셨으면 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix