Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Implement subtitle modifications for each encoder #1214

Merged
merged 7 commits into from
Jan 24, 2020
Merged

[IMPROVEMENT] Implement subtitle modifications for each encoder #1214

merged 7 commits into from
Jan 24, 2020

Conversation

NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Jan 23, 2020 •
edited
Loading

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I am an active contributor to CCExtractor.

Implement subtitle modification by moving it into ccx_encoders_common.c.

Add support for all CC_BITMAP and CC_608 subtitles. May segfault without #1216.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 23, 2020 •
edited
Loading

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 15/21
WTV 12/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@NilsIrl
Implement subtitle modification for all 608 encoders
93ef2f1 
This is done by modifying the subtitles in `ccx_encoders_common.c`
rather than per encoder.
@NilsIrl NilsIrl force-pushed the patch-1 branch 2 times, most recently from 47ef832 to 70c440f Compare January 23, 2020 23:56
@NilsIrl NilsIrl changed the title [IMPROVEMENT] Implement subtitle modifications for each encoder WIP [IMPROVEMENT] Implement subtitle modifications for each encoder Jan 24, 2020
@NilsIrl NilsIrl marked this pull request as ready for review January 24, 2020 01:18
@cfsmp3 cfsmp3 merged commit 8db3398 into CCExtractor:master Jan 24, 2020
@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 24, 2020 •
edited
Loading

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@NilsIrl NilsIrl deleted the patch-1 branch January 28, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NilsIrl @ccextractor-bot @cfsmp3