Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX]
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Looks like the MacOS build processes got left behind with some recent changes (e.g. moving zvbi).
After much travail, I've updated several components, and it now build fine through all three mechanisms. (Although not sure why you're keeping the
build.command
around, given the other mechanisms are much more flexible.).Notes below, but in particular, I've added the libpng NEON files necessary for building for the Apple Silicon Macs, and I've made the autoconf files identical for Mac and Linux (which fixed many of the Mac issues). Please let me know if you disagree with any of these changes. Happy to update this PR.
I should note that I have not tried building with rust yet at all. Is it materially better yet than the C version?
For all:
Add Neon files to libpng for Apple Silicon
Update compilation.md documentation
For autoconf:
Make Linux and Mac Makefile.am and configure.ac identical
Fix wrong location for zvbi/bcd.h in both Mac/Linux
For cmake:
Include GPAC config for Darwin in Mac version
For mac/build.command:
Update for new zvbi location