Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Mac Build processes #1390

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Repair Mac Build processes #1390

merged 2 commits into from
Nov 10, 2021

Conversation

mackworth
Copy link
Contributor

[FIX]

In raising this pull request, I confirm the following (please check boxes):

  • [ x ] I have read and understood the contributors guide.
  • [ x ] I have checked that another pull request for this purpose does not exist.
  • [ x ] I have considered, and confirmed that this submission will be valuable to others.
  • [ x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [ x ] I give this submission freely, and claim no ownership to its content.
  • [ x ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • [ x ] I absolutely love CCExtractor, but have only contributed once or twice before.
  • I am an active contributor to CCExtractor.

Looks like the MacOS build processes got left behind with some recent changes (e.g. moving zvbi).

After much travail, I've updated several components, and it now build fine through all three mechanisms. (Although not sure why you're keeping the build.command around, given the other mechanisms are much more flexible.).

Notes below, but in particular, I've added the libpng NEON files necessary for building for the Apple Silicon Macs, and I've made the autoconf files identical for Mac and Linux (which fixed many of the Mac issues). Please let me know if you disagree with any of these changes. Happy to update this PR.

I should note that I have not tried building with rust yet at all. Is it materially better yet than the C version?

For all:
Add Neon files to libpng for Apple Silicon
Update compilation.md documentation

For autoconf:
Make Linux and Mac Makefile.am and configure.ac identical
Fix wrong location for zvbi/bcd.h in both Mac/Linux

For cmake:
Include GPAC config for Darwin in Mac version

For mac/build.command:
Update for new zvbi location

For all:
  Add Neon files to libpng for Apple Silicon
  Update compilation.md documentation

For autoconf:
  Make Linux and Mac Makefile.am and configure.ac identical
  Fix wrong location for zvbi/bcd.h in both Mac/Linux

For cmake::
  Include GPAC config for Darwin in Mac version

For mac/build.command:
  Update for new zvbi location
@cfsmp3 cfsmp3 merged commit 0ebeec4 into CCExtractor:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants