[FEAT] Port all the common_* files, teletext and networking portions of libccx to rust
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbertronnie
force-pushed
the
port-utility-to-rust
branch
3 times, most recently
from
3ddd353
to
9db7b1c
Compare
elbertronnie
changed the title
utility.c to rustcommon_* files and teletext portions of libccx to rust
elbertronnie
changed the title
common_* files and teletext portions of libccx to rustcommon_* files, teletext and networking portions of libccx to rust
elbertronnie
changed the title
common_* files, teletext and networking portions of libccx to rustcommon_* files, teletext and networking portions of libccx to rust
elbertronnie
force-pushed
the
port-utility-to-rust
branch
5 times, most recently
from
16bd519
to
3c1d56b
Compare
elbertronnie
force-pushed
the
port-utility-to-rust
branch
from
e5d7aff
to
ff06589
Compare
|
@PunitLodha Can you review this PR? |
Could you make each commit a separate PR? If you can't, that means each change is not correctly isolated from the rest. We need each commit to be self-contained (at least don't break anything) and be reversible by itself - we don't want to merge a huge PR with lots of commits that must exist together. (we're still paying for playing fast-and-loose in the past) |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
This was referenced Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This PR aims to port most of the functions in files
common_*,teletext.h,telxcc.c,networking.cand certain parts ofutility.c(such as logging) to rust. Certain parts of the codebase is left blank if they are dependant on some code which this PR has not aimed to convert. Such parts will have to be revisited once their dependencies are also converted to rust.I have placed the new rust code inside a new crate named as
lib_ccxr, which is a normal rust library crate. This was because a static library crate does not allow doctests. This would also help in seperating ffi code to idiomatic Rust code. Since the Rust approach and C approach to solve a problem are very different, there are 3 layers of indirection I have used for porting:1. The C-FFI layer
This layers will have function names same as defined in C but with the prefix of
ccxr_. These functions will handle the conversion between C-native types and Rust-native types and then pass it on to the C-like Rust layer. These are the functions defined in theccx_rustcrate underlibccxr_exportsmodule.2. The C-like Rust layer
This layer will have function names same as defined in C but work with Rust-native types. The code written using these functions would still be procedural but in Rust, hence the name C-like Rust. The entire task of these functions will be to translate the procedural code to idiomatic Rust code. These are the functions defined in the
c_functions.rsfile in appropriate modules inside thelib_ccxrcrate.3. The Idiomatic Rust layer
This layer will be the code written as one is supposed to write in idiomatic Rust. It will have complete documentation and tests. This code will will be situated in the
lib_ccxrcrate.