Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor issue with spaces in teletext #930

Merged
merged 1 commit into from
Feb 14, 2018
Merged

[FIX] Minor issue with spaces in teletext #930

merged 1 commit into from
Feb 14, 2018

Conversation

mkver
Copy link
Contributor

@mkver mkver commented Feb 13, 2018

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I absolutely love CCExtractor, but have not contributed previously.

Currently setting a colour doesn't necessarily add a space even though the specifications mandate it. This commit is designed to change that.

This is designed to fix a different problem than #922. There is currently no space when the colour changes in teletext (except with --nofontcolor). See for example this sample which contains multiple instances of what I am talking about. The default output (with colours) contains the following (only lines that show this have been kept):

2
00:00:03,240 --> 00:00:06,039
<font color="#ffff00">Dann räumen wir</font>
<font color="#ffff00">mal aus, oder?</font><font color="#00ffff">Ja.</font>

4
00:00:18,200 --> 00:00:20,919
<font color="#00ff00">Toby, sag mal</font>
<font color="#00ff00">"Infrastruktur"!</font><font color="#ff00ff">"Infaschuktur".</font>


12
00:00:43,480 --> 00:00:46,319
<font color="#00ff00">Schön!</font>Und wie ist das so?

Whereas with --nofontcolor the output is:

2
00:00:03,240 --> 00:00:06,039
Dann räumen wir
mal aus, oder? Ja.

4
00:00:18,200 --> 00:00:20,919
Toby, sag mal
"Infrastruktur"! "Infaschuktur".

12
00:00:43,480 --> 00:00:46,319
Schön! Und wie ist das so?

As one sees without --nofontcolor there is no space between '?' and 'Ja' in the second line, between '!' and '"' in the fourth and between '!' and 'U' in the 12th line. This little patch adresses this.

Currently setting a colour doesn't necessarily add a space even though the specifications mandate it. This commit is designed to change that.
@cfsmp3 cfsmp3 merged commit 679a69f into CCExtractor:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants