[FEATURE] Allow build with hardsubx using cmake #966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Fixes #964
To allow building with hardsubx, option has been added along with checking for the libraries it requires which have been cross-checked with Makefile.am
ccextractor/linux/Makefile.am
Line 330 in 3d6a9f4
Below is the build result after implementing the changes and using cmake.
make -j8
was successful in compiling the source code. Below is the command used on a file to test.The required library for building with FFMPEG, "avfilter", was not listed in the required libraries and hence has been added to it. This was done in response to an error caused at the time of testing (due to absence of libavfilter-dev in my system), below is the error. Parameters used:
cd ./build
cmake -DWITH_FFMPEG=ON ../src/
make -j8
The tests were also done on a remote Digital Ocean droplet by forking the branch and hence are system independent and are working.