Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow build with hardsubx using cmake #966

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

thealphadollar
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixes #964

To allow building with hardsubx, option has been added along with checking for the libraries it requires which have been cross-checked with Makefile.am

ccextractor_CFLAGS += -DENABLE_HARDSUBX

Below is the build result after implementing the changes and using cmake.

screenshot from 2018-03-14 00-16-08

make -j8 was successful in compiling the source code. Below is the command used on a file to test.

screenshot from 2018-03-14 00-16-33

The required library for building with FFMPEG, "avfilter", was not listed in the required libraries and hence has been added to it. This was done in response to an error caused at the time of testing (due to absence of libavfilter-dev in my system), below is the error. Parameters used:
cd ./build
cmake -DWITH_FFMPEG=ON ../src/
make -j8

screenshot from 2018-03-14 00-13-29

The tests were also done on a remote Digital Ocean droplet by forking the branch and hence are system independent and are working.

@cfsmp3 cfsmp3 merged commit b2e83ea into CCExtractor:master Mar 13, 2018
@thealphadollar thealphadollar deleted the cmake-hardsubx branch March 13, 2018 19:59
thealphadollar added a commit to thealphadollar/ccextractor that referenced this pull request May 15, 2018
Currently the instructions to install with hardsubx are vague and a new method was added in PR CCExtractor#966
This method makes installation with HARDSUBX easy and hence has been added to the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No option to compile with HARDSUBX using cmake
2 participants