Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caption loss due to CW command #991

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

thetransformerr
Copy link
Contributor

@thetransformerr thetransformerr commented Jul 12, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • [ x] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • [ x] I am an active contributor to CCExtractor.

Whenever ClearWindow command is issued to currently visible window , the captions stored in window are not copied to screen , since only toggle, hide window and delete window command do that right now , therefore data was out, with this PR , the caption are copied to screen and printed if there is some data and window was visible when Clearwindow was issued.

@thetransformerr thetransformerr changed the title Thetransformerr patch 2 Fix caption loss due to CW command Jul 12, 2018
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@thetransformerr
Copy link
Contributor Author

Here is the video from user Dennis

http://www.mediafire.com/file/9c74rkn4q91xbr7/snippet10.ts/file

and output after change

1
00:00:01,868 --> 00:00:03,269
Male Narrator:
rated 14 plus, and may contain

2
00:00:04,604 --> 00:00:05,939
coarse language, violence,
nudity, mature subject matter,

*I haven't played the file , so hope timing is correct.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 18/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit 6b1ad99 into CCExtractor:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants