Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onholdtodelete and swipetodelete will not run at same time #437

Merged

Conversation

Deepanshuigtm
Copy link
Contributor

@Deepanshuigtm Deepanshuigtm commented Feb 10, 2024

Description

"Hold Gesture" for bulk deleting alarms and the "Swipe to Delete" functionality can run simultaneously

When attempting to use the "Hold Gesture" to initiate bulk deletion of alarms, the "Swipe to Delete" functionality can be triggered simultaneously. This behavior is inconsistent with the intended functionality, as the "Hold Gesture" should exclusively activate the bulk delete feature without interference from other gestures.

Proposed Changes

conditionally setting the direction property of the Dismissible widget based on the value of the isAnyAlarmHolded controller

Fixes #371

Screenshots

WhatsApp.Video.2024-02-10.at.1.55.56.PM.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@MarkisDev MarkisDev merged commit 624dc00 into CCExtractor:main Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants