Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Made : UI updates after selecting weather in the profile section #733

Merged

Conversation

ganidande905
Copy link
Contributor

Description

This PR fixes the issue where weather selection in the Profile section was not updating after closing the dialog. The issue was caused because profileModel was not passed as an argument when navigating to /add-update-alarm, leading to an incomplete state update.

Proposed Changes

  • Passed profileModel as an argument in Get.toNamed('/add-update-alarm').
  • Ensured weatherTypes correctly updates from profileModel.value.weatherTypes.
  • UI now reflects selected weather types after closing the dialog.

Fixes #674

Screenshots

Screenshot_2025-03-10-19-09-23-48_a53a7893e903efe7d38a33066bfd52df
Screenshot_2025-03-10-19-09-31-95_a53a7893e903efe7d38a33066bfd52df

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@ganidande905
Copy link
Contributor Author

@MarkisDev can you review this PR, and merge if there is no conflict
Thank you

@MarkisDev MarkisDev merged commit ecbf9f5 into CCExtractor:main Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Inconsistency in the weather section
2 participants