Add Node List Function With Baremetal and Lease Info #6
Conversation
There was a problem hiding this comment.
Okay, after taking a closer look at the fields being returned, I'm of the opinion that we should just add the power state properties into the values that esi node list returns; everything else is already returned by that command. I suppose that was the purpose of the command in the first place; to more easily merge the two.
| @@ -16,6 +16,48 @@ | |||
| from esi.lib import networks | |||
|
|
|||
|
|
|||
| def node_list_full_info(connection): | |||
| """Get a list of nodes with more attributes | |||
There was a problem hiding this comment.
I'd clarify this as "list of nodes with information from Ironic and ESI-Leap"
| @@ -61,7 +103,7 @@ def network_list(connection, filter_node=None, filter_network=None): | |||
| 'network_info': [ | |||
| { | |||
| 'baremetal_port': openstack.baremetal.v1.port.Port, | |||
| 'network_port': [openstack.network.v2.port.Port] or [], | |||
| 'network_ports': [openstack.network.v2.port.Port] or [], | |||
There was a problem hiding this comment.
Does this effect python-esiclient?
There was a problem hiding this comment.
This does not affect python-esiclient, just a documentation error
| baremetal_nodes = list(f2.result()) | ||
|
|
||
| esi_nodes.sort(key=lambda node: node.name) | ||
| baremetal_nodes.sort(key=lambda node: node.name) |
There was a problem hiding this comment.
I admit that this sort of implicit matching makes me nervous, especially because I think Ironic node names don't actually have to be unique. In addition it depends on the two services returning the same list of nodes - which they should do, but if the behavior changes in one then the results will be messed up.
|
How would those properties be added? Is that something that be changed in esisdk? Or from the service endpoint? I'm guessing part of it will be adding to esi/lease/v1/node.py |
|
It's done here: https://github.com/CCI-MOC/esi-leap/blob/master/esi_leap/api/controllers/v1/node.py#L65. Possibly the esisdk would need to be updated as well. If you'd like, I'd be fine with temporarily having the join restricted to the UI code, with plans to remediate later. |
|
I'm ok with fixing this later |
No description provided.