Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Openstacksdk Version and Documentation Error #7

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ajamias
Copy link
Collaborator

@ajamias ajamias commented Jul 10, 2024

No description provided.

@ajamias ajamias force-pushed the main branch 4 times, most recently from 706c960 to 9861af2 Compare July 15, 2024 19:39
@ajamias ajamias marked this pull request as draft July 15, 2024 20:00
@tzumainn
Copy link
Collaborator

This is a python 3.7 issue; I think we can remove it from testing, since as lars mentioned Ironic explicitly requires 3.8+ now. I'd match what he did to esi-leap; remove anything before 3.8 and add 3.12.

Other packages need higher versions of openstacksdk,
resulting in a dependency conflict. Relaxing the
dependency in esisdk will solve the conflict. Ironic
now requires Python >= 3.8, so the tests were changed
to reflect that.
@ajamias ajamias marked this pull request as ready for review July 19, 2024 14:25
Copy link
Collaborator

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@tzumainn tzumainn merged commit e195735 into CCI-MOC:main Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants