This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
setup.py: Shore up dependency version specifications #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been historically sloppy about how we specify these; some of these have been pinned to exact versions (unnecessarily preventing security and bug fixes), others have just not specified version constraints at all. This patches defines, documents, and implements a policy. The timing for this patch has to do with the upcoming keystone authentication backend; our previous version constraint on the requests package unnecessarily conflicted with the constraint specified by python-keystoneclient.
|
+1 |
|
+1, looks good to me. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to keep the keystone auth pr as small as possible, I'm submitting this self-contained change. Per the commit message, python-keystoneclient requires a version of requests that conflicts with the one that we (needlessly) specified. It was easy enough to just fix the whole thing (and document the policy) so I went ahead and did it.
@gsilvis, @knikolla, @henn please have a look.