This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Keystone: admins needn't be in the db #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized a fairly glaring error in my test; will fix when I get back to my machine. |
| Openstack projects. | ||
| Openstack projects. This is true even for projects not that do not exist | ||
| within HaaS; such projects will not be able to own resources (such as | ||
| nodes networks, etc), but may preform admin-only operations (such as |
|
Looks good with the anticipated test change. In addition to a positive test checking that a different project-admin can access stuff, would it be possible to add a negative test too that ensures a regular user with authorization to a non-HIL project can't access anything? |
...otherwise bootstrapping is hard.
zenhack
force-pushed
the
keystone-admin-bootstrapping
branch
from
9ec1a2f
to
6f1b88f
Compare
|
@henn, just fixed the typo and the test, and pushed. Tests pass on my local machine, just waiting on travis. re: the test you propose, I believe this is what |
|
Looks good. +1 |
|
+1, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...otherwise bootstrapping is hard.
Per our discussion on #615.
//cc @henn, @gsilvis, @knikolla