Add classes to model pod metrics and project invoices. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
force-pushed
the
refactor/invoice_class
branch
from
fe56aae
to
289c4ae
Compare
naved001
commented
Sep 30, 2024
openshift_metrics/invoice.py
Outdated
| gpu_request: Decimal, | ||
| memory_request: Decimal, | ||
| gpu_type: str, | ||
| gpu_resource: str, |
There was a problem hiding this comment.
I think I should add namespace, the kubernetes node label, and the node model as part of a pod definition. Those would come in handy when I produce reports by pods.
There was a problem hiding this comment.
and most importantly the name of the pod itself
knikolla
reviewed
Sep 30, 2024
QuanMPhm
reviewed
Sep 30, 2024
openshift_metrics/invoice.py
Outdated
| elif gpu_type == GPU_A100_SXM4: # for MIG GPU of type A100_SXM4 | ||
| su_type = A100_SXM4_MIG.get(gpu_resource, SU_UNKNOWN_MIG_GPU) | ||
| else: | ||
| return SU_UNKNOWN_GPU, 0, "GPU" |
There was a problem hiding this comment.
Should these return statements use the ServiceUnit tuple like this?:
return ServiceUnit(SU_UNKNOWN_GPU, 0, "GPU")
There was a problem hiding this comment.
yes they should! good catch.
openshift_metrics/invoice.py
Outdated
|
|
||
| # pods that requested a specific GPU but weren't scheduled may report 0 GPU | ||
| if gpu_resource is not None and gpu_count == 0: | ||
| return SU_UNKNOWN_GPU, 0, "GPU" |
openshift_metrics/invoice.py
Outdated
|
|
||
| return ServiceUnit(su_type, su_count, determining_resource) | ||
|
|
||
| def get_runtime(self, ignore_hours=None): |
There was a problem hiding this comment.
What's the point of the ignore_hours argument?
There was a problem hiding this comment.
I should remove this, I plan to add a feature to ignore certain hours from calculating runtime. I'll add this in argument when I add that feature.
naved001
force-pushed
the
refactor/invoice_class
branch
from
289c4ae
to
34beebe
Compare
The class `Pod` represent a pod's metrics and exposes methods to get the service unit and runtime of a pod. The service unit information is returned as a namedtuples. The method to get runtime will allow us to ignore certain hours, though, that will be added in a later commit. The class `ProjectInvoice` represents invoice data for a project. It has a method that takes in a pod and aggregates it's usage data. Another method `generate_invoice_rows` will return the csv data to be exported. The caller write_metrics_by_namespace has been updated to use these new classes. Tests have been updated to work with the new changes. There's some duplicate constants that I will sort in the next few commits.
naved001
force-pushed
the
refactor/invoice_class
branch
from
34beebe
to
d93b2d7
Compare
QuanMPhm
approved these changes
Oct 3, 2024
knikolla
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
Podrepresent a pod's metrics and exposes methods to get the service unit and runtime of a pod. The service unit information is returned as a namedtuple. The method to get runtime will allow us to ignore certain hours, though, that will be added in a later commit.The class
ProjectInvoicerepresents invoice data for a project. It has a method that takes in a pod and aggregates it's usage data. Another methodgenerate_invoice_rowswill return the csv data to be exported.The caller write_metrics_by_namespace has been updated to use these new classes.
Tests have been updated to work with the new changes. There's some duplicate constants that I will sort in the next few commits.
The method write_metrics_by_pod isn't updated yet since it's not critical and I wanted to keep the size of this PR down.