Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESI CLI to return properties as dictionaries in lease,offer and node list #55

Merged
merged 1 commit into from
May 13, 2024

Conversation

skanthed
Copy link
Collaborator

@skanthed skanthed commented May 9, 2024

No description provided.

Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One request - I think there's probably a formatted_node_properties variable in fakes.py that can be removed - can you get rid of it?

@skanthed
Copy link
Collaborator Author

@tzumainn --
Do we need to update the lease_show and offer_show functions as well? They currently return strings and utilize formatted_node_properties

@tzumainn
Copy link
Contributor

Ah, yes - good catch!

@skanthed
Copy link
Collaborator Author

@tzumainn I will update the PR.

@tzumainn
Copy link
Contributor

Looks good - thanks!

@tzumainn tzumainn merged commit 04dec16 into CCI-MOC:master May 13, 2024
6 checks passed
@skanthed skanthed self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants