Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Two Datasets opened in parallel via OPeNDAP are loaded into same resource #306

Closed
HelenClifton opened this issue Aug 1, 2017 · 13 comments
Closed
Assignees
Milestone

Comments

@HelenClifton
Copy link

Expected behavior

If more than one dataset is loaded into memory via OPeNDAP at the same time, expect a separate resource to be created for each one.

Actual behavior

The tasks panel indicates that cate is only creating one resource and both datasets are being loaded into it.

Steps to reproduce the problem

  1. Clear the workspace or create a new one

  2. From ESA CCI Open Data Portal list, select esacci.AEROSOL.5-days.L3C.AEX.GOMOS.Envisat.aergom.2-19.r1 then click on “Download and/or open remote dataset”

  3. In the “Download Data Source” window:
    • Deselect time, region, variable constraints.
    • Deselect “Download and make local data source”.
    • Select “open dataset from remote”
    • Click “Open Remote”

capture - parallel datasets opendap 1

  1. In Tasks panel, observe there is a new task displayed “Opening dataset res_1 from esacci.AEROSOL.5-days.L3C.AEX.GOMOS.Envisat.aergom.2-19.r1”

  2. From ESA CCI Open Data Portal list, select esacci.OZONE.mon.L3.NP.multi-sensor.multi-platform.MERGED.fv0002.r1 then click on “Download and/or open remote dataset”

  3. In the “Download Data Source” window:
    • Deselect time, region, variable constraints.
    • Deselect “Download and make local data source”.
    • Select “open dataset from remote”
    • Click “Open Remote”

capture - parallel datasets opendap 2

  1. In Tasks panel, observe there is a new task displayed “Opening dataset res_1 from esacci.OZONE.mon.L3.NP.multi-sensor.multi-platform.MERGED.fv0002.r1”

capture - parallel datasets opendap 3

Specifications

Cate 0.9.0-dev.4
Windows 7 Professional

@HelenClifton
Copy link
Author

Same happens if trying to open more than one local dataset at the same time

@mzuehlke mzuehlke added the gui label Aug 21, 2017
@forman forman added the bug label Aug 31, 2017
@forman forman self-assigned this Sep 6, 2017
@forman
Copy link
Member

forman commented Sep 6, 2017

User should be able to provide a unique resource name

@forman
Copy link
Member

forman commented Sep 13, 2017

@mzuehlke remember, 0.9.0-dev.5 in you've implemented a feature Prevent a 2nd (and 3rd) invocation of the variable statistics computation (but created no issue which I could ref here). This is another application of your fix. I'll try to generalize it for any operation invocation.

@forman
Copy link
Member

forman commented Sep 15, 2017

For 1.0, it is sufficient to ensure unique resource names. Later we'll add a feature to let users provide their own resource names when opening datasets and applying operations. See #369.

@HelenClifton
Copy link
Author

In cate-0.9.0-dev7 the functionality in the Download Data Source dialog to load into memory via OPeNDAP has been disabled.
In cate-0.9.0-dev7 it is still possible to open two local datasets in parallel and they will be assigned the same resource name. Will retest in 1.0.0.

@forman
Copy link
Member

forman commented Sep 26, 2017

In cate-0.9.0-dev7 the functionality in the Download Data Source dialog to load into memory via OPeNDAP has been disabled.

Oops, OPeNDAP should be used automatically if any constraints are used. @kbernat, no?

In cate-0.9.0-dev7 it is still possible to open two local datasets in parallel and they will be assigned the same resource name. Will retest in 1.0.0.

Yes, yes, I have an idea...

@forman
Copy link
Member

forman commented Sep 27, 2017

@HelenClifton I cannot reproduce your problem.

image

What exactly have you done to open two datasets that have same resource names?

@mzuehlke
Copy link
Collaborator

@forman can it be that the fix has only been merged after the release of 0.9.0.dev7 ?

@forman
Copy link
Member

forman commented Sep 27, 2017

Yes. Shame on me.

@forman
Copy link
Member

forman commented Sep 27, 2017

Furthermore, the OPeNDAP option has accidentally been removed while resolving #366! I will reintroduce it.

@forman
Copy link
Member

forman commented Sep 27, 2017

It's not true. OPeNDAP should be used automatically when you uncheck option "Download and make local data source". I will clarify this with a tooltip in 1.0.

Sorry for this confusion, too many activities in parallel.

@forman
Copy link
Member

forman commented Sep 27, 2017

@HelenClifton it'd be great if you could take a look again in 1.0.0.dev1 on Monday

@HelenClifton
Copy link
Author

@forman Confirmed FIXED in 1.0.0.dev2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants