Skip to content

Conversation

@harryswift01
Copy link
Contributor

@harryswift01 harryswift01 commented Jun 18, 2025

Summary

This PR aims to improve the test coverage of the entropy.py module by implementing atomic tests for its classes and functions. The goal is to ensure the correctness of logic and numerical computations throughout the module.


Changes

Restructured Testing Order

  • Adopted a class-based structure for test cases, aligning with the format used in other parts of the codebase.
  • Improved readability and maintainability by grouping related tests.

Expanded Unit Tests for Core Functions

  • Added atomic tests for all major functions and classes in entropy.py.
  • Included tests for _process_united_atom_level, _finalize_molecule_results, and orientational_entropy_calculation.

Enhanced Type and Output Validation

  • Implemented tests to verify expected input/output types.
  • Ensured correct formation of selection_string in water entropy calculations.

Impact

  • Significantly increases test coverage for entropy.py, improving confidence in the module’s reliability.
  • Helps catch regressions and logic errors early in development.
  • Aligns testing practices with the rest of the codebase for consistency.

…_process_united_atom_level` refined function name for test to remain consistency
… implementing atomic tests for all of the Entropy classes and functions
… is correctly formed with the use of water entropy
@harryswift01 harryswift01 linked an issue Jun 18, 2025 that may be closed by this pull request
@harryswift01 harryswift01 changed the title Improve test coverage for entropy Improve Test Coverage for entropy.py Jun 18, 2025
@harryswift01 harryswift01 self-assigned this Jun 18, 2025
@harryswift01 harryswift01 modified the milestone: 1.0.0 release Jun 18, 2025
@harryswift01 harryswift01 requested review from jimboid June 18, 2025 10:57
Copy link
Member

@jimboid jimboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo and fixed it, tests look comprehensive

@harryswift01 harryswift01 merged commit 80e6c05 into main Jun 23, 2025
7 checks passed
@harryswift01 harryswift01 deleted the 93-improve-test-coverage-for-entropy branch June 23, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Test Coverage for entropy.py

3 participants