Skip to content

Improve Test Coverage for levels.py #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harryswift01 merged 4 commits into from
Jun 23, 2025
Merged

Improve Test Coverage for levels.py #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aed4c55
Add atomic test cases for `levels.py` to ensure isolated functionalit…
harryswift01 Jun 16, 2025
60542f2
Merge branch 'main' of https://github.com/CCPBioSim/CodeEntropy into …
harryswift01 Jun 18, 2025
317bd92
additional test cases for `levels.py`, extending the coverage for the…
harryswift01 Jun 18, 2025
ebe7d9a
added in `pragma: no cover` flags to identify that these are mathemat…
harryswift01 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CodeEntropy/levels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,14 +441,17 @@ def get_sphCoord_axes(self, arg_r):
if x2y2 == 0.0:
raise ValueError("x2y2 is zero, cannot compute sin_phi and cos_phi.")

# These conditions are mathematically unreachable for real-valued vectors.
# Marked as no cover to avoid false negatives in coverage reports.

# Check for non-negative values inside the square root
if x2y2 / r2 < 0:
if x2y2 / r2 < 0: # pragma: no cover
raise ValueError(
f"Negative value encountered for sin_theta calculation: {x2y2 / r2}. "
f"Cannot take square root."
)

if x2y2 < 0:
if x2y2 < 0: # pragma: no cover
raise ValueError(
f"Negative value encountered for sin_phi and cos_phi "
f"calculation: {x2y2}. "
Expand All @@ -462,7 +465,7 @@ def get_sphCoord_axes(self, arg_r):
sin_phi = arg_r[1] / np.sqrt(x2y2)
cos_phi = arg_r[0] / np.sqrt(x2y2)

else:
else: # pragma: no cover
sin_theta = 0.0
cos_theta = 1

Expand Down
Loading