Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #192, allowing the force_partitioning argument to be changed.
Changes
Force_partitioning argument changes value used in calculation:
Impact
Force_partitioning parameter can now be changed as shown below for two examples with force_partitioning = 0.5 and force_partitioning = 1.
While we haven't yet identified any cases for which a value different to 0.5 is necessary, changing this might be useful in the future and is useful for investigating vibrational entropy terms, especially the rovibrational one.
Warning about using a different value to 0.5 remains and displays the default value, as shown below (example above was computed before this change. Example below was computed for a small number of frames just to illustrate this change) :
Closes: Force partitioning remains 0.5 even if changing the parameter #192