Skip to content

Conversation

@ioanaapapa
Copy link
Collaborator

Summary

This PR addresses #192, allowing the force_partitioning argument to be changed.

Changes

Force_partitioning argument changes value used in calculation:

  • build_covariance_matrices in EntropyManager now includes a force_partitioning parameter, which takes the value of the of force_partitioning argument in cli/config.yaml file
  • subsequent functions in levels.py called by build_covariance_matrices now also include this parameter, rather than just using the default value, 0.5.
  • warning now shows 0.5 as the default value of this parameter.

Impact

  • Force_partitioning parameter can now be changed as shown below for two examples with force_partitioning = 0.5 and force_partitioning = 1.

  • image
  • image
  • While we haven't yet identified any cases for which a value different to 0.5 is necessary, changing this might be useful in the future and is useful for investigating vibrational entropy terms, especially the rovibrational one.

  • Warning about using a different value to 0.5 remains and displays the default value, as shown below (example above was computed before this change. Example below was computed for a small number of frames just to illustrate this change) :

  • image
  • Closes: Force partitioning remains 0.5 even if changing the parameter #192

@harryswift01 harryswift01 added the bug Something isn't working label Nov 18, 2025
@ioanaapapa ioanaapapa marked this pull request as draft November 18, 2025 15:23
- addition of the `force_partitioning` parameter to the test suite
@ioanaapapa ioanaapapa marked this pull request as ready for review November 18, 2025 15:40
Copy link
Contributor

@harryswift01 harryswift01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for adding these changes @ioanaapapa, it is greatly appreciated! Initially we wanted to wait for a stable release of CodeEntropy before we would allow users to change certain parameters like the force_partitioning but I think we are now at that stage where we're happy for users to tweak these parameters. I'm very happy to approve and merge this in.

@harryswift01 harryswift01 merged commit 97df881 into main Nov 18, 2025
15 checks passed
@harryswift01 harryswift01 deleted the 192-force-partitioning branch November 18, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force partitioning remains 0.5 even if changing the parameter

3 participants