Skip to content

Conversation

@harryswift01
Copy link
Contributor

@harryswift01 harryswift01 commented Mar 11, 2025

Summary

This PR is apart of the major refactor of CodeEntropy, as the poseidon code is now being replaced with imports from waterEntropy which handles water entropy. The current poseidon code is no longer required hence its removal from CodeEntropy.

Changes

Poseidon Removal :

  • Removed the everything in the CodeEntropy/poseidon/ directory
  • Removed the CodeEntropy/PoseidonHelper.py file

Updates to `pyproject.toml' File:

  • The Removal of poseidon got rid of most of the warnings related to issue Local Variables Assigned and Never Used #52 of local variables being assigned and not used
  • One variable that was assigned but not used within Example/create_new_universe.py has been commented out
  • Due to issue Local Variables Assigned and Never Used #52 being resolved the extend-ignore case for variables assigned but never used (F841) has been removed from the pyproject.toml file

Impact

  • Structural Changes: The removal of the poseidon code significantly changes how CodeEntropy operates, as it now relies on external imports from waterEntropy to handle water entropy. This simplifies the CodeEntropy codebase and ensures that future development will be more modular and easier to maintain.
  • Codebase Cleanliness: By eliminating the poseidon code, we reduce code duplication and improve readability. This makes the repository more focused on the core functionality of entropy calculations, without the need to manage outdated or unnecessary components.
  • Bug Fixes: Resolving issue Local Variables Assigned and Never Used #52, where unused local variables were causing warnings, also improves the overall quality of the code. This should lead to fewer errors and cleaner builds moving forward.
  • Configuration Update: The change in the pyproject.toml file optimizes the configuration for linting and style checks. The removal of the unused variable exception (F841) will make it easier to spot actual issues in the code and enforce better coding practices.

- Removed the everything in the CodeEntropy/poseidon/ directory
- Removed the CodeEntropy/PoseidonHelper.py file
- Resolved issue #52 of local variables being assigned and not used
 - Removal of poseidon got rid of most of the warnings
 - One variable that was assigned but not used within Example/create_new_universe.py has been commented out
- Due to issue #52 being resolved the extend-ignore case for variables assigned but never used (F841) has been removed from the pyproject.toml file
@harryswift01 harryswift01 added this to the WP7 - Refactor milestone Mar 11, 2025
@harryswift01 harryswift01 requested a review from jimboid March 11, 2025 16:30
@harryswift01 harryswift01 self-assigned this Mar 11, 2025
This was linked to issues Mar 11, 2025
Copy link
Member

@jimboid jimboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got it all, nice you tightened up the linter in pyproject.toml

@harryswift01 harryswift01 merged commit 4d66bb7 into main Mar 12, 2025
6 checks passed
@harryswift01 harryswift01 deleted the 58-posiedon-code-removal branch March 12, 2025 08:47
@jimboid jimboid modified the milestones: WP7 - Refactor, 1.0.0 release Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Posiedon Code Removal Local Variables Assigned and Never Used

3 participants