Resolve issue #68 where there was a mismatch in the args naming convention #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am going to be annoying and ask if maybe the variable name should be changed to temperature rather than using an abbreviation (or having conflicts between different variations on the abbreviation)? |
Contributor
Author
|
@skfegan yeah this makes more sense now, thanks for double checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue whereby the naming convention on the new argument handler didn't correctly have the correct association, which resulted in a crash in the program as it was not in the
arg_mapdictionary.Changes
Re-named variables: :
args.temptoargs.temperatureImpact
args.tempdeclaration