Skip to content

Commit

Permalink
Remove TODOs that are actually to-done
Browse files Browse the repository at this point in the history
  • Loading branch information
karlhigley committed Dec 18, 2024
1 parent a33ba60 commit 3d9ec2d
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,6 @@ def __call__(self, clicked_articles: ArticleSet, interest_profile: InterestProfi
if len(clicked_articles.articles) == 0:
interest_profile.embedding = None
else:
# TODO: Add descriptions of the topics, maybe in a dictionary?
# TODO: Embed the topic description to make a lookup table of topics
# - Need the news encoder from NRMSArticleEmbedder in order to feed the descriptions into
# TODO: Create virtual "clicks" based on the topics
# TODO: Feed the combined history of real and virtual clicks into `build_user_embedding`
article_embedder = NRMSArticleEmbedder(
model_path=model_file_path("nrms-mind/news_encoder.safetensors"), device=self.device
)
Expand Down

0 comments on commit 3d9ec2d

Please sign in to comment.