Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to build and test docker image #25

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

mdekstrand
Copy link
Contributor

To reduce risk of future errors as we work on refactoring and other improvements, this PR does some minimal docker cleanups and adds docker-based testing of the repo to main-branch pushes and PRs.

Doesn't work yet due to outstanding problems with request formats.

@mdekstrand mdekstrand requested a review from karlhigley June 13, 2024 22:21
Copy link
Collaborator

@karlhigley karlhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main, which has a fix for the request parsing issues

@@ -15,7 +15,7 @@
"url": "url 2"
}
],
"click_data": [
"click_histories": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we've fixed this six times this week already, but...reverting the big dependency management change undid it again 😓

@mdekstrand mdekstrand marked this pull request as ready for review June 14, 2024 17:09
@mdekstrand mdekstrand linked an issue Jun 14, 2024 that may be closed by this pull request
@mdekstrand mdekstrand merged commit e9c6991 into main Jun 14, 2024
1 check passed
@mdekstrand mdekstrand deleted the mdekstrand/ci-docker branch June 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CI for testing the lambda endpoints
2 participants