Revise path logic and move models and data to top-level #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdekstrand
force-pushed
the
mdekstrand/refactor-model-locations
branch
from
38c025d to
104ca26
Compare
karlhigley
reviewed
Jun 17, 2024
mdekstrand
force-pushed
the
mdekstrand/refactor-model-locations
branch
from
d02a6d6 to
022a15f
Compare
karlhigley
approved these changes
Jun 17, 2024
| @@ -36,7 +36,7 @@ def recsys_metric(recommendations, row_index, news_struuid_ID): | |||
| # use the url of Article | |||
| impressions_truth = ( | |||
| pd.read_table( | |||
| src_dir() / "data" / "test_mind_large" / "behaviors.tsv", | |||
| f"{project_root()}/data/test_mind_large/behaviors.tsv", | |||
There was a problem hiding this comment.
Let's keep the pathlib style here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the path-location logic and rearranges the repository structure to be more logical and reduce wasted space during Docker image build:
src,data,modelsdirectories for source code, input data, and model checkpoints, respectively.model_file_pathfunction to locate a model file, checking in aPOPROX_MODELSenvironment variable, the project root, and the Conda environment prefix, in that order. This will enable POPROX model data to be stored in a data location during deployment.project_rootand makes it search based on the current working directory, looking forpyproject.toml, so that it can work seamlessly regardless of whether and howpoprox_recommendershas been installed.It also adds tests for the
pathsmodule, and depends on #31 and the docker tests to make sure none of this breaks our code in a way that can be detected at test time.